Remove polyfillMemoryLeakPrevention #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Sep 17, 2018
|
CI is failing due to Node 4 being dropped by ember-data@2.18.5 😩. I don't think we need ember-data here so we should probably remove it and confirm that it fixes the CI issue. |
|
D'oh! Done. |
|
CI should be unblocked by #338 |
|
@tmquinn - Can you drop the last commit (we ended up needing ember-data) and rebase against master? Should be good to merge after that... |
tmquinn
force-pushed
the
remove-polyfillMemoryLeakPrevention
branch
3 times, most recently
from
1517e8f to
a7f078c
Compare
As of qunit@2.6.0, this polyfill is no longer necessary and can cause issues in apps the implement ember-qunit
tmquinn
force-pushed
the
remove-polyfillMemoryLeakPrevention
branch
from
a7f078c to
c23c06b
Compare
|
Thank you @tmquinn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of qunit@2.6.0, this polyfill is no longer necessary and can cause issues
in apps the implement ember-qunit