Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require host to provide testing fixture DOM elements. #741

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 17, 2020

Instead of ember-qunit automatically injecting some DOM elements into test-body (via the contentFor hook) this requires the project itself to add these DOM elements.

This dove tails with the changes to make qunit a peer dependency as this now puts the app in full control of the testing fixtures.

See:


For applications migrating, add the following just under your existing {{content-for "test-body"}} entry in your tests/index.html:

    <div id="qunit"></div>
    <div id="qunit-fixture">
      <div id="ember-testing-container">
        <div id="ember-testing"></div>
      </div>
    </div>

Instead of `ember-qunit` automatically injecting some DOM elements into
`test-body` (via the `contentFor` hook) this requires the project itself
to add these DOM elements.

This dove tails with the changes to make `qunit` a peer dependency as
this now puts the app in full control of the testing fixtures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant