Require host to provide testing fixture DOM elements. #741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
ember-qunit
automatically injecting some DOM elements intotest-body
(via thecontentFor
hook) this requires the project itself to add these DOM elements.This dove tails with the changes to make
qunit
a peer dependency as this now puts the app in full control of the testing fixtures.See:
#ember-testing-container
into#qunit-fixture
element. ember-test-helpers#910@ember/test-helpers
andqunit
. #738For applications migrating, add the following just under your existing
{{content-for "test-body"}}
entry in yourtests/index.html
: