Override #qunit-fixture styling, place inside viewport #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitpaulk
force-pushed
the
rohitpaulk/fix-qunit-fixture-position
branch
from
dbce66f to
a531c8d
Compare
|
Yep, I completely missed when this was posted. Sorry @rohitpaulk, will review today. |
rwjblue
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
As discussed over in the original issue, I think going with the simpler CSS override approach is good enough (even though I generally worry about the coupling, if QUnit decides to change its styling) and the alternative is a bit messy implementation wise (though it would be fully in our control).
|
Thanks @rwjblue and @rohitpaulk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #764
Tested using this dummy app.