Replace hard-coded guides link with /current #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acorncom what happens if the guides are restructured at some point and the link no longer points to anything useful? |
|
@acorncom - Is this still the best path forward? |
|
@rwjblue yes, that URL should be fine. Are you referring to the current vs latest discussion we had a few months ago? |
|
Ya, but I mostly just want to see if this is the right path forward, rebase, and merge if it is... |
|
Needs a rebase 😭 |
|
No worries! |
rwjblue
approved these changes
Jul 14, 2018
This was referenced Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type of link works fine for guides at this point. We might also want to use the Ember version of the app in question, thoughts?