Refactors setupOnerror to be a pure setup/teardown approach #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first version of
setupOnerror
was wired up to the new hooks APIsetupContext
/teardownContext
functions, ensuring that the correct teardown occurred for each test.The old API, however, could leak the patched
Ember.onerror
as the teardown would never be called.This PR makes the utilities simple, in that it simply provides the patching capabilities. It's expected that
ember-qunit
will wire up the teardown inQUnit.testDone
, or some equivalent. This will also be the path forward forember-mocha
, using a globalafterEach
.