Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors setupOnerror to be a pure setup/teardown approach #548

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

scalvert
Copy link
Contributor

The first version of setupOnerror was wired up to the new hooks API setupContext/teardownContext functions, ensuring that the correct teardown occurred for each test.

The old API, however, could leak the patched Ember.onerror as the teardown would never be called.

This PR makes the utilities simple, in that it simply provides the patching capabilities. It's expected that ember-qunit will wire up the teardown in QUnit.testDone, or some equivalent. This will also be the path forward for ember-mocha, using a global afterEach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants