allow getProperties and setProperties for component integration tests #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only if you don't want it removed as "unused" in a future refactor 😝 |
|
Also, 👍 on this, maybe we should add |
|
I was about to submit such a PR. I think this is a useful addition.
👍 |
CodeOfficer
force-pushed
the
set-properties
branch
from
c28b726
to
4105cd2
Compare
CodeOfficer
changed the title
|
that work for ya? |
|
Test failures were fixed in #79, restarting Travis build. |
rwjblue
added a commit
that referenced
this pull request
Jul 20, 2015
allow getProperties and setProperties for component integration tests
|
Thank you! |
|
Released in ember-qunit@0.4.2. |
|
Thanks @CodeOfficer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this worth testing? O.o