[BUGFIX release] Deprecate Ember.keys.

emberjs · Jun 21, 2015 · 1ed73ac · 1ed73ac
1 parent 501d473
commit 1ed73ac
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/packages/ember-metal/lib/main.js b/packages/ember-metal/lib/main.js
@@ -223,7 +223,6 @@ Ember._Cache = Cache;
 
 Ember.generateGuid    = generateGuid;
 Ember.GUID_KEY        = GUID_KEY;
-Ember.keys            = Object.keys;
 Ember.platform        = {
   defineProperty: true,
   hasPropertyAccessors: true
@@ -408,5 +407,6 @@ if (Ember.__loader.registry['ember-debug']) {
 }
 
 Ember.create = Ember.deprecateFunc('Ember.create is deprecated in-favour of Object.create', Object.create);
+Ember.keys = Ember.deprecateFunc('Ember.keys is deprecated in-favour of Object.keys', Object.keys);
 
 export default Ember;
diff --git a/packages/ember-metal/tests/main_test.js b/packages/ember-metal/tests/main_test.js
@@ -32,8 +32,13 @@ QUnit.test('SEMVER_REGEX properly validates and invalidates version numbers', fu
   validateVersionString('1.11', false);
 });
 
+QUnit.test('Ember.keys is deprecated', function() {
+  expectDeprecation(function() {
+    Ember.keys({});
+  }, 'Ember.keys is deprecated in-favour of Object.keys');
+});
 
-QUnit.test('Ember.create is deprecated', function() {
+QUnit.test('Ember.keys is deprecated', function() {
   expectDeprecation(function() {
     Ember.create(null);
   }, 'Ember.create is deprecated in-favour of Object.create');

diff --git a/packages/ember-routing/lib/system/router_state.js b/packages/ember-routing/lib/system/router_state.js
@@ -1,4 +1,5 @@
-import Ember from 'ember-metal/core';
+import isEmpty from 'ember-metal/is_empty';
+import keys from 'ember-metal/keys';
 import EmberObject from 'ember-runtime/system/object';
 import merge from 'ember-metal/merge';
 
@@ -11,7 +12,7 @@ var RouterState = EmberObject.extend({
     var state = this.routerJsState;
     if (!this.routerJs.isActiveIntent(routeName, models, null, state)) { return false; }
 
-    var emptyQueryParams = Ember.isEmpty(Ember.keys(queryParams));
+    var emptyQueryParams = isEmpty(keys(queryParams));
 
     if (queryParamsMustMatch && !emptyQueryParams) {
       var visibleQueryParams = {};
@@ -37,4 +38,3 @@ function shallowEqual(a, b) {
 }
 
 export default RouterState;
-
diff --git a/packages/ember/tests/component_registration_test.js b/packages/ember/tests/component_registration_test.js
@@ -1,5 +1,6 @@
 import 'ember';
 import Ember from 'ember-metal/core';
+import keys from 'ember-metal/keys';
 
 import compile from 'ember-template-compiler/system/compile';
 import helpers from 'ember-htmlbars/helpers';
@@ -12,7 +13,7 @@ function prepare() {
   Ember.TEMPLATES['components/expand-it'] = compile('<p>hello {{yield}}</p>');
   Ember.TEMPLATES.application = compile('Hello world {{#expand-it}}world{{/expand-it}}');
 
-  originalHelpers = Ember.A(Ember.keys(helpers));
+  originalHelpers = Ember.A(keys(helpers));
 }
 
 function cleanup() {
@@ -28,7 +29,7 @@ function cleanup() {
 }
 
 function cleanupHandlebarsHelpers() {
-  var currentHelpers = Ember.A(Ember.keys(helpers));
+  var currentHelpers = Ember.A(keys(helpers));
 
   currentHelpers.forEach(function(name) {
     if (!originalHelpers.contains(name)) {