-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #11425 from emberjs/fix-container-view-hooks
Fix container view hooks
- Loading branch information
Showing
4 changed files
with
84 additions
and
18 deletions.
There are no files selected for viewing
57 changes: 57 additions & 0 deletions
57
packages/ember-htmlbars/tests/integration/will-destroy-element-hook-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
import run from 'ember-metal/run_loop'; | ||
import Component from 'ember-views/views/component'; | ||
import compile from 'ember-template-compiler/system/compile'; | ||
import { runAppend, runDestroy } from "ember-runtime/tests/utils"; | ||
|
||
import { set } from 'ember-metal/property_set'; | ||
|
||
var component; | ||
|
||
QUnit.module('ember-htmlbars: destroy-element-hook tests', { | ||
teardown() { | ||
runDestroy(component); | ||
} | ||
}); | ||
|
||
QUnit.test('willDestroyElement is only called once when a component leaves scope', function(assert) { | ||
var innerChild, innerChildDestroyed; | ||
|
||
component = Component.create({ | ||
switch: true, | ||
|
||
layout: compile(` | ||
{{~#if switch~}} | ||
{{~#view innerChild}}Truthy{{/view~}} | ||
{{~/if~}} | ||
`), | ||
|
||
innerChild: Component.extend({ | ||
init() { | ||
this._super(...arguments); | ||
innerChild = this; | ||
}, | ||
|
||
willDestroyElement() { | ||
if (innerChildDestroyed) { | ||
throw new Error('willDestroyElement has already been called!!'); | ||
} else { | ||
innerChildDestroyed = true; | ||
} | ||
} | ||
}) | ||
}); | ||
|
||
runAppend(component); | ||
|
||
assert.equal(component.$().text(), 'Truthy', 'precond - truthy template is displayed'); | ||
assert.equal(component.get('childViews.length'), 1); | ||
|
||
run(function() { | ||
set(component, 'switch', false); | ||
}); | ||
|
||
run(function() { | ||
assert.equal(innerChild.get('isDestroyed'), true, 'the innerChild has been destroyed'); | ||
assert.equal(component.$().text(), '', 'truthy template is removed'); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters