Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested link-tos cause broken active states (beta, canary) #10662

Closed
mixonic opened this issue Mar 18, 2015 · 4 comments
Closed

Nested link-tos cause broken active states (beta, canary) #10662

mixonic opened this issue Mar 18, 2015 · 4 comments
Milestone

Comments

@mixonic
Copy link
Member

mixonic commented Mar 18, 2015

Using nested link-to, ala this common omg-using-bootstrap pattern:

{{#link-to 'cats' tagName="li"}}
  {{link-to "Cats Page" "cats"}}
{{/link-to}}

Causes broken active states in beta and canary. See: http://emberjs.jsbin.com/pejavu/4/edit?html,css,js

This is a regression from 1.10 (broken in 1.11.0-beta.1). It seems that when the currentWhen is compared to the states on the jsRouter that those states still reflect a loading state. For example:

We've seen a variety of manifestations, including active not being set and ember-transitioning-in and ember-transitioning-out being stuck on.

@bantic
Copy link
Member

bantic commented Mar 18, 2015

This jsbin might be helpful. It makes a distinction between the outer nested links (no underline) and the inner nested links (underlined) and you can see that if you always click the outer nested links the correct behavior is observed.

http://jsbin.com/sowuja/2

(edit linked bin)

@rwjblue
Copy link
Member

rwjblue commented Mar 18, 2015

Duplicate of #10366.

@rwjblue rwjblue added this to the 1.11.0 milestone Mar 18, 2015
@mixonic
Copy link
Member Author

mixonic commented Mar 18, 2015

Closing as a dupe!

@mixonic mixonic closed this as completed Mar 18, 2015
@alexspeller
Copy link
Contributor

An alternative solution is https://github.com/alexspeller/ember-cli-active-link-wrapper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants