Add nested link-to test. #10726
Merged
Add nested link-to test. #10726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mixonic - I feel that I am getting trolled (this should not be passing?!?!!?), but I cannot for the life of me see what is different... |
|
@rwjblue I have something similar I believe should cause it to trigger: beta...mixonic:argh But no failure. And this is against beta. |
|
Argh!! I'll continue digging in the morning. With hopefully a fresh mind. |
rwjblue
force-pushed
the
nested-link-to
branch
2 times, most recently
from
4a473d3
to
4828e9b
Compare
Ensures that a no-op transition returns the currently active transition (was previously returning a new transition which messed up the transition state classes).
|
Updated router.js (here) to ensure that a no-op transition returns the currently active transition (was previously returning a new transition which messed up the transition state classes). Example JSBin: http://emberjs.jsbin.com/yopexu/1/edit?html,js,output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not seem to trigger the issue in #10366 and #10662, though I cannot see a major difference between the test here and the failing JSBin: http://emberjs.jsbin.com/pejavu/4/edit?html,js,output.
I will continue to bang on it...