[REGRESSION] On re-render, newly-added sub-views of non-dirty parent components have wrong parentView

[jder]

It appears that 1.13.0 through 1.13.2 have a bug relative to 1.12.2 in which newly-added items in an each loop get a parentView set to the template's view rather than the component in which they appear in the template. Here is a JS bin demonstrating the issue:

http://jsbin.com/butavikavi/edit?html,js,console,output

Essentially, code like this:

{{#parent-component}}{{#each ...}}{{child-component}}{{/each}}{{/parent-component}}

The child components will have parent-component as their parentView, but on re-render if a new child-component appears, its parent view will be whatever view houses the template, not the parent-component.

[jder]

This has the same behavior in v2.0.0-beta.1 as in 1.13.2.

[jder]

I'm looking more into this. So far, I've found that this isn't {{#each}}-specific; you can reproduce the same thing with an {{#if}}, as well, if a new view is added.

[jder]

I've put together a PR for this. It's a bit of a hack, and there's probably a nicer solution possible; feedback welcome. At least, there's a simple test case in there someone could reuse.

The problem seems to come down to the fact that when a parent component is not dirty, HTMLBars never asks for it to generate an env for its children. This is solved for keywords with a special check while visiting all nodes, which is hooked up to the childEnv function on keywords. There's no equivalent place for components to provide such a callback, so I'm populating it directly on the node.

Perhaps the problem is that the env is not the right place to store this info in the first place?