Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array methods marked as private #12004

Closed
alexspeller opened this issue Aug 6, 2015 · 1 comment
Closed

Array methods marked as private #12004

alexspeller opened this issue Aug 6, 2015 · 1 comment

Comments

@alexspeller
Copy link
Contributor

#11362 marks lots of array methods, e.g. forEach and sortBy, as private. Surely this can't be correct?

@rwjblue is this intentional?
@mixonic
Copy link
Member

mixonic commented Aug 7, 2015

@alexspeller this was with the goal of making all doc privacy settings explicit. forEach and sortBy both seem like public API to me and a PR would be welcome marking them public on beta.

duggiefresh added a commit to duggiefresh/ember.js that referenced this issue Aug 7, 2015
@duggiefresh
[DOC release] Mark Ember.Array methods as public
d9c3027 
- compact
- every
- forEach
- without
- sortBy

Closes emberjs#12004
[ci skip]
@duggiefresh duggiefresh mentioned this issue Aug 7, 2015
Merged
rwjblue pushed a commit to rwjblue/ember.js that referenced this issue Aug 8, 2015
@duggiefresh @rwjblue
[DOC release] Mark Ember.Array methods as public
acf85f0 
- compact
- every
- forEach
- without
- sortBy

Closes emberjs#12004
[ci skip]

(cherry picked from commit d9c3027)
rwjblue pushed a commit that referenced this issue Aug 9, 2015
@duggiefresh @rwjblue
[DOC release] Mark Ember.Array methods as public
25181b9 
- compact
- every
- forEach
- without
- sortBy

Closes #12004
[ci skip]

(cherry picked from commit d9c3027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexspeller @mixonic