Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] The 4.12 docs on Disabling Prototype Extensions are not updated according to RFC: Deprecate array prototype extensions #848 #20465

Closed
johanrd opened this issue May 30, 2023 · 1 comment

Comments

@johanrd
Copy link
Contributor

johanrd commented May 30, 2023

📙 Describe the Issue

The 4.12 docs on Disabling Prototype Extensions are not updated according to RFC: Deprecate array prototype extensions #848

🔬 Minimal Reproduction

From the Ember 4.12.0 docs on Disabling Prototype Extensions:

By default, Ember.js will extend the prototypes of native JavaScript arrays to implement the Ember.Enumerable, Ember.MutableEnumerable, Ember.MutableArray and Ember.Array interfaces. This polyfills ECMAScript 5 array methods in browsers that do not implement them, adds convenience methods and properties to built-in arrays, and makes array mutations observable.

🤔 Expected Behavior

No longer mention that ember by default extends the prototypes of native JavaScript arrays to implement the Ember.Enumerable, Ember.MutableEnumerable, Ember.MutableArray and Ember.Array interfaces.

Perhaps also mention in the docs of the MutableArray class that ember no longer has Array prototype extension enabled by default?

@kategengler
Copy link
Member

This RFC has not yet been implemented. You can track progress here emberjs/rfcs#1020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants