Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start breaking up Ember.View code into mixins based on purpose #10320

Merged
merged 6 commits into from
Jan 31, 2015

Conversation

ebryn
Copy link
Member

@ebryn ebryn commented Jan 31, 2015

@drogus
Copy link
Contributor

drogus commented Jan 31, 2015

I'm curious, what's the purpose of this refactoring? Do you think these could be used outside of View or is it more for separation of concerns?

@ebryn
Copy link
Member Author

ebryn commented Jan 31, 2015

@drogus I'm working on "metal views", the view layer performance improvements. Generally, I think it's useful to break apart massive classes such as Ember.View into their logical pieces so you can easily see how things fit together.

mmun added a commit that referenced this pull request Jan 31, 2015
Start breaking up Ember.View code into mixins based on purpose
@mmun mmun merged commit 422c626 into emberjs:master Jan 31, 2015
@rwjblue
Copy link
Member

rwjblue commented Jan 31, 2015

I'd like to see these mixins in separate files instead of all in the same place, but clearly that can be a later refactoring.

@drogus
Copy link
Contributor

drogus commented Jan 31, 2015

I'm working on "metal views", the view layer performance improvements

Sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants