<base href and <embed src data: need to be escaped #10695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stefanpenner
commented
Mar 22, 2015
stefanpenner
commented
- add tests for this (fixed in HTMLBars)
- remove misleading code and test (this all happens in HTMLBars now)
- update NPM dep of HTMLBars to be the released one.
* add tests for this (fixed in HTMLBars) * remove misleading code and test (this all happens in HTMLBars now)
|
Added commit updating HTMLBars to 0.11.2 (just published). Also, this will need to be cherry-picked into beta branch. |
rwjblue
added a commit
that referenced
this pull request
Mar 23, 2015
<base href and <embed src data: need to be escaped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.