Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ember.Checkbox extend from Ember.Component #11396

Merged
merged 1 commit into from
Jun 10, 2015

Conversation

cibernox
Copy link
Contributor

Public API unchanged.

@mixonic
Copy link
Member

mixonic commented Jun 10, 2015

@cibernox per this burndown: #11377 we would like to make sure this does NOT go into 1.13 beta, but instead lands only in 2.0.

@rwjblue can we merge this to master? Don't want to trip you up.

@cibernox
Copy link
Contributor Author

This can wait 3 days until the 12th.

If you feel that is convenient for organization purposes of that burndown merge all those changes in a single PR you can cherry-pick this commit and close this.

@mixonic
Copy link
Member

mixonic commented Jun 10, 2015

@bantic and I are working on that burndown- definitely merging changes as we go.

rwjblue added a commit that referenced this pull request Jun 10, 2015
Make Ember.Checkbox extend from Ember.Component
@rwjblue rwjblue merged commit 3189a1e into emberjs:master Jun 10, 2015
@cibernox cibernox deleted the make-ember-checkbox-a-component branch June 10, 2015 15:28
@rwjblue
Copy link
Member

rwjblue commented Jun 10, 2015

I think there is an issue that is open about this that we can close now.

@pangratz
Copy link
Member

@rwjblue this one #5433?

@rwjblue
Copy link
Member

rwjblue commented Jun 10, 2015

Yes, thank you!

@jfelchner
Copy link

Thanks for all the hard work everyone. It's very much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants