Commits on Jun 20, 2015

1. [BUGFIX beta] {{link-to}} before application boot …

   Previously, {{link-to}} would work even if the application had not been
   booted completely. This behavior is relied on by test harnesses like
   ember-qunit, since an “integration test” of a component may include a
   template that uses {{link-to}}. Many people have discovered that they
   would like to test a component that has a link without booting the
   entire app.
   
   > You wanted a banana but what you got was a gorilla holding the banana
   > and the entire jungle. –Joe Armstrong
   
   During the Glimmer work, we refactored the interface between the
   LinkComponent and the router into a service. Unfortunately, this
   caused a regression where rendering the link before the router was
   completely initialized would raise an exception.
   
   This commit adds a very stupid guard to ensure that we have enough
   router state to determine if a link is active or not. This whole path
   could be significantly cleaned up, and in particular, we should move
   towards using a stubbed routing service in tests that encapsulates all
   of these concerns.

   

   tomdale committed Jun 20, 2015
   Configuration menu

   • View commit details
   • Copy full SHA for c9dbecb
   • Browse repository at this point

   Copy the full SHA

   c9dbecb View commit details

   Browse the repository at this point in the history