[CLEANUP beta] Remove deprecated registry behaviour #11756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibernox
force-pushed
the
remove_deprecated_registry_behavior
branch
from
771cb5a
to
5c007d6
Compare
* Registry no longer instantiates a container and forwards lookup/lookupFactory to it. * Removed checks for `ember-application-instance-initializers` and `ember-application-initializer-context` since they have been enabled by default for ~4 months now.
cibernox
force-pushed
the
remove_deprecated_registry_behavior
branch
from
5c007d6
to
5ab3b54
Compare
|
Cc @dgeb |
does this mean this PR is not needed? |
|
So @rwjblue and I have devised a plan related to this PR and #11440 - see #11440 (comment) #11440 won't land until after 2.0, so we can proceed with merging these changes prior to 2.0. I'll rebase this PR (since I caused the delay) and, if needed, add any significant changes in a separate commit. |
|
Closing in favor of #11853. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-application-instance-initializersandember-application-initializer-contextsince they have been enabled by default for ~4 months now.