Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP beta] Remove deprecated Ember.View support from Ember global #11794

Merged
merged 1 commit into from Jul 17, 2015
Merged

[CLEANUP beta] Remove deprecated Ember.View support from Ember global #11794

merged 1 commit into from Jul 17, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 17, 2015

Addresses global exports listed in #11775

@ghost ghost changed the title [WIP][CLEANUP beta] Remove deprecated Ember.View support [CLEANUP beta] Remove deprecated Ember.View support from Ember global Jul 17, 2015
@rwjblue
Copy link
Member

rwjblue commented Jul 17, 2015

This looks like it addresses the global exports for #11775, lets land this then continue to work down that list.

@rwjblue
Copy link
Member

rwjblue commented Jul 17, 2015

  • Removing Ember.View._Renderer here is causing tests/node/app-boot-test.js to fail (which means ember-cli-fastboot needs to be updated to grab this from another location). We can export it as Ember._Renderer for now (unless @mixonic or @tomdale have another preference), then PR to ember-cli-fastboot to do something like var Renderer = Ember._Renderer || Ember.View._Renderer;.
  • Update tests/node/app-boot-test.js to extend from Ember.Component here
  • Ember.View needs to be changed to use Ember.Component helper here

@ghost
Copy link
Author

ghost commented Jul 17, 2015

Should this be included in this or a other pull request?

@rwjblue
Copy link
Member

rwjblue commented Jul 17, 2015

I think it will need to be this one, because the node test suite (which is required for Travis to be green) will not pass without the above changes.

Also, you can run these tests yourself via bin/run-node-tests.js (assuming you have an instance of ember server or npm start running).

@ghost
Copy link
Author

ghost commented Jul 17, 2015

Thats much faster then TEST_SUITE=node npm test

I have added the changes to the node tests.

@rwjblue
Copy link
Member

rwjblue commented Jul 17, 2015

ember-fastboot/ember-cli-fastboot#51 updates ember-cli-fastboot to use Ember._Renderer if present, I'll merge that shortly after this is merged.

@ghost
Copy link
Author

ghost commented Jul 17, 2015

I was just about to open a PR for that, but you beat me to it. 👍

rwjblue added a commit that referenced this pull request Jul 17, 2015
[CLEANUP beta] Remove deprecated Ember.View support from Ember global
@rwjblue rwjblue merged commit 8e03e3a into emberjs:master Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants