-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [CLEANUP beta] Drop legacy helper APIs, some legacy Handlebars usage #11858
Conversation
…amespace Drop: * Bare function helpers (legacy handlebars compat) * View helpers * makeBoundHelper
#11900 adds deprecations for all of these older helper styles, in preparation for this PR removing them... |
Needs work to be mergeable. I'd like to land this before 2.0.0-beta.5 (so that folks have a chance to digest with one last beta before final 2.0.0). I know that you are fighting with local build issues (I'm sorry), please let me know if you think this is in jeopardy of not being ready in the next day or two and I can try to pick it up... |
replaced by #11965 |
In 2.0 we drop:
Ember.Handlebars.makeViewHelper
,Ember.HTMLBars.makeViewHelper
)Ember.Handlebars.makeBoundHelper
)Ember.Handlebars.registerHelper
Ember.HTMLBars._registerHelper
This PR is very much WIP (my setup is whack), but I wanted to get it out there in case any one else was looking at this part of the 2.0 changes.
This requires and audit of deprecations messages in 1.13 to ensure everything is properly deprecated.