Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Remove double loop over attrs to create a component. #12297

Merged
merged 1 commit into from
Sep 5, 2015
Merged

[BUGFIX beta] Remove double loop over attrs to create a component. #12297

merged 1 commit into from
Sep 5, 2015

Commits on Sep 4, 2015

  1. [BUGFIX beta] Remove double loop over attrs to create a component. 

    Previously, we would loop over `attrs` and create additional objects for
each entry then subsequently merge that "snapshot" back into a target
object TWICE for initial render.

This updates to loop once over the attrs and do all the work needed in
that one pass. It also avoids allocating two temporary objects and the
extra `Object.assign` to merge them back into the target.
    @rwjblue
    rwjblue committed Sep 4, 2015
    Configuration menu
    Copy the full SHA
    f4a3059 View commit details
    Browse the repository at this point in the history