Use Cache for tagname operations.
#12309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid running a regexp match against the same string many times. * Avoid searching the same string for a dash many times. * Change `Cache` to use `new EmptyObject()` since we do not need `delete` support, we don't need to force into "slow mode"
|
@stefanpenner - Can you 👍 / 👎 the changes to |
| import Cache from 'ember-metal/cache'; | ||
|
|
||
| var IS_ANGLE_CACHE = new Cache(1000, function(key) { | ||
| return key.match(/^(@?)<(.*)>$/); |
There was a problem hiding this comment.
this RegExp looks like kirby 👍
|
@rwjblue looks good, Cache actually has internal instrumentation. Can you share the hit/miss info? |
|
After running the "Render for 10 seconds" perf test on ef4/initial-render-perf: Both caches have: 14443 hits and 5 misses |
nice |
rwjblue
added a commit
that referenced
this pull request
Sep 9, 2015
Use `Cache` for tagname operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cacheto usenew EmptyObject()since we do not needdeletesupport, we don't need to force into "slow mode"Timing shows a small improvement (tested against ef4/initial-render-perf):
Before: 164ms average (for 10 runs)
After: 159ms average (for 10 runs)