IE8 Fix for host object array filter #12334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,7 +101,7 @@ var filter = defineNativeShim(ArrayPrototype.filter, function(fn, context) { | |||
| var length = this.length; | |||
|
|
|||
| for (i = 0; i < length; i++) { | |||
| if (this.hasOwnProperty(i)) { | |||
| if (typeof this.hasOwnProperty !== 'function' || this.hasOwnProperty(i)) { | |||
There was a problem hiding this comment.
this should instead be Object.prototype.hasOwnProperty.call(this, i);
There was a problem hiding this comment.
@stefanpenner I replaced that code. But then Travis CI test failed for Safari. Not able to find the reason so i reverted back to same code which passed before. Now Travis CI test fails for IE9. Issue with travis?
There was a problem hiding this comment.
The cross browser builds are finicky, please change this back as Stef mentioned and I'll restart the build if it fails again.
There was a problem hiding this comment.
@rwjblue Yes, the same code passed now..
|
LGTM, can you squash your commits ? |
IE8 doesn't define hasOwnProperty for host objects
acid-srvnn
force-pushed
the
release-1-13
branch
from
0ecaad9
to
e893af9
Compare
rwjblue
added a commit
that referenced
this pull request
Sep 13, 2015
IE8 Fix for host object array filter
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUGFIX release-1-13] IE8 doesn't define hasOwnProperty for host objects, So execution of
Array.prototype.filter.call(document.getElementsByTagName('li'),function(){return true});causesObject doesn't support property or method 'hasOwnProperty'error.