Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release] ArrayProxy#content should not be a computed property #12860

Closed
wants to merge 1 commit into from
Closed

[BUGFIX release] ArrayProxy#content should not be a computed property #12860

wants to merge 1 commit into from

Commits on Jan 24, 2016

  1. [BUGFIX release] ArrayProxy should not be a computed property 

    Fixes emberjs#12475.

This commit restores the contract of ArrayProxy content being a simple
property instead of a computed property. This prevents accidental
clobberings such as in ember-data:

https://github.com/emberjs/data/blob/v2.3.3/addon/-private/system/record-arrays/record-array.js#L44

This commit also removes a private hook `arrangedContentArrayWillChange`.
In the interest of keeping this bugfix commit minimal, we will continue
removing the will* hooks on canary.
    @mmun
    mmun committed Jan 24, 2016
    Configuration menu
    Copy the full SHA
    15eb964 View commit details
    Browse the repository at this point in the history