Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Remove vestigial path normalization in chains #12929

Merged
merged 3 commits into from
Feb 9, 2016

Conversation

mmun
Copy link
Member

@mmun mmun commented Feb 8, 2016

This fixes a bug that occurs when chaining through a property that starts with a capital letter.

Here is a JSBin with a demonstration of the bug.

deprecate(
`Connecting an Ember.Binding to a global path such as '${this._from}' is deprecated. Please use a service instead.`,
false,
{ id: 'ember-metal.global-bindings', until: '3.0.0' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make an entry in the deprecation guide and add a url property here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss whether we want to deprecate all of Ember.Binding first. I think we should.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On that note I am going to remove the deprecation from this particular PR.

@mmun mmun changed the title Deprecate global bindings and rewrite them to avoid global chains [BUGFIX] Remove vestigial path normalization in chains Feb 8, 2016
@mmun
Copy link
Member Author

mmun commented Feb 8, 2016

Kris pointed out a couple other things that should be cleaned up before merging:

And we should do some performance testing to see how much of a win it is.

@stefanpenner
Copy link
Member

🔥 🎉

Removes support for paths containing globals and "this". These were
intended to be removed at the time when globals support was removeded
from Ember.get/set and from inside of temlates, e.g.

```hbs
{{SomeGlobal.foo}}
```
@rwjblue
Copy link
Member

rwjblue commented Feb 9, 2016

Thanks @mmun!

rwjblue added a commit that referenced this pull request Feb 9, 2016
[BUGFIX] Remove vestigial path normalization in chains
@rwjblue rwjblue merged commit 632a254 into master Feb 9, 2016
@rwjblue rwjblue deleted the rm-global-chains branch February 9, 2016 17:37
@@ -219,20 +232,20 @@ Binding.prototype = {

/* Called when the from side changes. */
fromDidChange(target) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this arg doesn't seem one used anymore?

@krisselden
Copy link
Contributor

This should be documented as breaking but since the behavior made no sense and didn't align with templates I doubt this will bite anyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants