[BUGFIX beta] Add private WeakMap #12990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let weak = this.writableWeak(); | ||
| return weak[symbol] = value; | ||
| }; | ||
|
|
|
Can we make this at least bugfix beta, as it will allow completion of the computed sort fix. |
|
@stefanpenner Sounds good... should I rebase it down to three [BUGFIX beta] commits for you, Travis and me? |
|
yay! |
|
@mmun sure |
krisselden
added a commit
that referenced
this pull request
Feb 20, 2016
[BUGFIX beta] Add private WeakMap
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards fixing #12212. Finishes #12417 and #12224.
Implements a partial polyfill for WeakMap.
There is a small but important caveat. This implementation assumes that the weak map will live longer (in the sense of garbage collection) than all of its keys otherwise it is possible to leak the values stored in the weak map. In practice, most use cases satisfy this limitation which is why it is included in ember-metal.