Revert "[BUGFIX canary] Update Ember.compare to use operators" #13036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this @krisselden! |
rwjblue
added a commit
that referenced
this pull request
Mar 2, 2016
…r-compare Revert "[BUGFIX canary] Update Ember.compare to use operators"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a breaking change to make compare be locale invariant from using the default locale and many locales do not default to being case sensitive for sorting. Non localizable data like sorting ids needs an invariant compare and yes that is a valid use case but I don't see how we could switch this now, collation affects not just case sensitivity but accent sensitivity and more. This change makes it compare character code values, which is fine for locale invariant data like base64 encoded ids but not necessarily ok for names.