Update tagging strategy #20753
Open
Update tagging strategy #20753
+252
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is preparation to make it possible to have more than one published package living in this monorepo. It changes the tagging strategy so that releases of ember-source should be tagged like `v6.0.0-ember-source` instead of `v6.0.0`.
kategengler
reviewed
Sep 20, 2024
| @@ -126,7 +126,7 @@ jobs: | |||
| run: pnpm vite build --mode=development | |||
|
|
|||
| - name: Set BrowserStack Local Identifier | |||
| if: startsWith(github.ref, 'refs/tags/v') | |||
| if: startsWith(github.ref, 'refs/tags/v') && endsWith(github.ref, '-ember-source') | |||
There was a problem hiding this comment.
Apparently you still cannot comment on unchanged lines on github:
Do we want to run this workflow at all for changes and or tags of @glimmer/component?
There was a problem hiding this comment.
Yes. The CI workflow is good test coverage for everything together, including @glimmer/component.
With #20751 we'll actually get better integration test coverage of @glimmer/component than we've ever had.
|
I PR'd with a more comprehensive update to RELEASE.md #20754 The only other concern I have is that PRs for @glimmer/component will show up in the changelog via script for |
Update RELEASE.md
kategengler
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation to make it possible to have more than one published package living in this monorepo.
It changes the tagging strategy so that releases of ember-source should be tagged like
v6.0.0-ember-sourceinstead ofv6.0.0.