[BUGFIX release] Fix finishChains #5575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // finish any current chains node watchers that reference obj | ||
| chainWatchers = m.chainWatchers; | ||
| if (chainWatchers) { | ||
| for(var key in chainWatchers) { |
There was a problem hiding this comment.
Object.keys or custom chainsNodesFrom instead of hasOwnProperty check should prevent potential deopt of key in chainWatchers
There was a problem hiding this comment.
Slight pedantic note: if we need Object.keys behavior we should use Ember.keys instead (it is basically Object.keys when that exists but still works in ES3 browsers).
There was a problem hiding this comment.
As far as I know, this isn't the slow case (chainWatchers are always simple objects and copied), and I'm hesitant to make this change as part of this pull, since none of the other code in chains.js is using keys over for/in, I'd rather see the switch to keys() uniformly in chains with some cross browser perf data.
krisselden
force-pushed
the
fix-finish-chains
branch
from
801dc85
to
dda26bc
Compare
…j not just the ones rooted at that object.
krisselden
force-pushed
the
fix-finish-chains
branch
from
dda26bc
to
971b65e
Compare
krisselden
added a commit
that referenced
this pull request
Sep 22, 2014
[BUGFIX release] Fix finishChains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
finishChainsfor all chains that reference an obj not just the ones rooted at that object.