Deprecate Windows support #1038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyselden
reviewed
Jul 9, 2024
|
|
||
| > There are tradeoffs to choosing any path, please attempt to identify them here. | ||
|
|
||
| ## Alternatives |
There was a problem hiding this comment.
Maybe refactoring the ember cli test suite to not take as long should go here?
There was a problem hiding this comment.
absolutely -- but this problem extends beyond ember-cli, too -- all CIs in all projects that test windows
There was a problem hiding this comment.
another alternative:
running tests in parallel: ember-cli/ember-cli#10488
|
imo this should not go forward, even if it not easy to deal with in ci and so on, it's such a widely used operating system that I don't think we can go forward with this. |
|
A few community members have spoken (here and on Discord) -- I will close. Thanks for letting me know how important this is for ya'll! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HUGE DISCLAIMER:
I don't know if this is something that I seriously want to push forward, but I wanted feedback from the community. I don't know what systems folks work on, or what their environments are.
(I also may be alone in my feeling / frustration of Windows -- my posting of this RFC does not inherently reflect the stance of ember core team(s))
If official support for non-WSL windows is important to you, let me know (and if you know how to make GitHub CI faster with windows, also please let me know 😅 )
(all of the motivation here is related to CI speed, and this RFC is deliberately not fully fleshed out (and CI deliberately red))
Propose {{RFC_NAME}}
Rendered
Summary
This pull request is proposing a new RFC.
To succeed, it will need to pass into the Exploring Stage), followed by the Accepted Stage.
A Proposed or Exploring RFC may also move to the Closed Stage if it is withdrawn by the author or if it is rejected by the Ember team. This requires an "FCP to Close" period.
An FCP is required before merging this PR to advance to Accepted.
Upon merging this PR, automation will open a draft PR for this RFC to move to the Ready for Released Stage.
Exploring Stage Description
This stage is entered when the Ember team believes the concept described in the RFC should be pursued, but the RFC may still need some more work, discussion, answers to open questions, and/or a champion before it can move to the next stage.
An RFC is moved into Exploring with consensus of the relevant teams. The relevant team expects to spend time helping to refine the proposal. The RFC remains a PR and will have an
Exploringlabel applied.An Exploring RFC that is successfully completed can move to Accepted with an FCP is required as in the existing process. It may also be moved to Closed with an FCP.
Accepted Stage Description
To move into the "accepted stage" the RFC must have complete prose and have successfully passed through an "FCP to Accept" period in which the community has weighed in and consensus has been achieved on the direction. The relevant teams believe that the proposal is well-specified and ready for implementation. The RFC has a champion within one of the relevant teams.
If there are unanswered questions, we have outlined them and expect that they will be answered before Ready for Release.
When the RFC is accepted, the PR will be merged, and automation will open a new PR to move the RFC to the Ready for Release stage. That PR should be used to track implementation progress and gain consensus to move to the next stage.
Checklist to move to Exploring
S-Proposedis removed from the PR and the labelS-Exploringis added.Checklist to move to Accepted
Final Comment Periodlabel has been added to start the FCP