Advance RFC #0995 "Deprecate non-co-located components." to Stage Recommended

[emberjs-rfcs-bot]

Advance #995 to the Recommended Stage

Rendered

Summary

This pull request is advancing the RFC to the Recommended Stage.

• PR to Accepted Stage: Deprecate non-colocated components. #995
• PR to Ready For Release Stage
• PR to Released Stage

An FCP is required before merging this PR to advance.

Recommended Stage Summary

The "Recommended" stage is the final milestone for an RFC. It provides a signal to the wider community to indicate that a feature has been put through its ecosystem paces and is ready to use.

To reach the "Recommended" stage, the following should be true:

If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.

If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.

If the proposal updates or replaces an existing feature, high-quality codemods are available.

If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.

If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".

Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met.

An FCP is required to enter this stage. Multiple RFCs may be moved as a batch into "Recommended" with the same PR.

Checklist to move to Recommended

• Criteria specific to this feature: Any additional criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met.
• Tutorial: If appropriate, the feature is integrated into the tutorial.
• Guides: If appropriate, the feature is integrated into the guides prose.
• API Docs: API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.
• Addon Ecosystem: If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.
• Codemods: If the proposal updates or replaces an existing feature, high-quality codemods are available.
• Debugging Tools: If needed, Ember debugging tools (e.g. Ember Inspector, Deprecation Workflow) have been updated to support the feature.
• IDE Support: If needed, popular IDE support has been updated to support the feature.
• Engines, SSR: If needed, ecosystem feature such as Ember Engines, SSR support have been updated to support the feature.
• Blueprints: Blueprints have been updated to support the feature and to reflect the new best practices implied by this feature.
• Linting: Lint rules have been updated or added or removed to support the feature and to reflect the new best practices implied by this feature.
• Deprecations: If this feature implies that other features are no longer best practice, RFCs have been created to deprecate those features.
• Blog Post: Consider if a blog post should be written to introduce this feature to the community.
• Feature Suite: If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".
• FCP to Recommended: This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP.

Criteria for moving to Recommended (required)

<-- Copy and paste the criteria for "Recommended" from the Ready For Release stage here -->

A set of criteria for moving this RFC to the Recommended Stage, following release:

1. Deprecate and/or remove --component-structure=classic option from the component and component-class blueprints.
2. Embroider should deprecate non co-located templates Projects on embroider don't see the "Non-colocated components" deprecation embroider-build/embroider#2066

[ef4]

The only remaining piece of work we identified just now is removing deprecating the options to the blueprints that generate non-colocated components.

[ef4]

Review this and the checklist items above are still the correct remaining todos.

[ef4]

Need to land embroider-build/embroider#2088 to fix the lack of deprecation message on embroider.

[ef4]

Status update: the only remaining piece of work is cleaning up the old option on the generator.