Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul store.push and store.pushPayload #161

Closed
wants to merge 7 commits into from
Closed

Overhaul store.push and store.pushPayload #161

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7a7c78e
ember-data: overhaul store push
pangratz Aug 1, 2016
ba2cf2d
Fix formatting
pangratz Aug 1, 2016
61a8562
Add question for `store.pushPayload` being deprecated
pangratz Aug 2, 2016
6e1e3a3
Add drawback of refernces leaked into user land
pangratz Aug 2, 2016
0b53be0
Fix typo
pangratz Aug 2, 2016
b13ccc3
s/pushRef/pushDocument/ and mention DocumentReference
pangratz Oct 20, 2016
e2439d2
s/pushRef/pushDocument/ and link to DocumentReference
pangratz Oct 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion text/0000-ember-data-overhaul-store-push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,11 @@ use cases are supported with this.
introduces those type of reference to the public
([`store.getReference`](http://emberjs.com/api/data/classes/DS.Store.html#method_getReference)
is not really helpful at the moment). It is questionable if returning
references is needed here. Since we have a `store.normalizePayload` now, it is
references is needed here and in general, if references are intented for this
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/intented/intended/

kind of usage. This might suggest storing references (controller, component)
for later use - which is not the intended use for references...

Since we have a `store.normalizePayload` now, it is
possible to normalize a payload and get the corresponding models via
`store.push`. There is no immediate need for `store.pushRef`. But if a pushing
data into the store without materializing records should be possible, having a
Expand Down