Assure gts works #206
Assure gts works #206
Conversation
| @@ -86,6 +86,18 @@ for (let packageManager of SUPPORTED_PACKAGE_MANAGERS) { | |||
| 'template-registry.js.map', | |||
| ]); | |||
|
|
|||
| expect(distContents.hashed.length).toBe(4); | |||
| expect( | |||
There was a problem hiding this comment.
if anyone knows of a more ergonomic way to do this, I'm all ears
| @@ -0,0 +1,3 @@ | |||
| import templateOnly from '@ember/component/template-only'; | |||
There was a problem hiding this comment.
this file is needed so that Glint knows what type the hbs file is.
In TS, we cannot have bare-hbs-file-components.
| @@ -86,6 +86,18 @@ for (let packageManager of SUPPORTED_PACKAGE_MANAGERS) { | |||
| 'template-registry.js.map', | |||
| ]); | |||
|
|
|||
| expect(distContents.hashed.length).toBe(4); | |||
There was a problem hiding this comment.
Why is it 4, and is this necessarily the case? Or are we assuming rollup implementation details here, and potentially making the test brittle?
There was a problem hiding this comment.
rollupSomething js + map
template-only js + map
Previously the rollup files were filtered out
I do not believe the test would become brittle (all 4 files have hashes in their names, so I can't directly check what their file names are)
| distContents.hashed | ||
| .filter(file => file.includes('template-only')) | ||
| .map(file => file.split('.js')[1]) | ||
| ).to.deep.equal(["", '.map'], 'the template-only component is emitted with a source map'); |
There was a problem hiding this comment.
Are these additional assertions related to gts support? Or why are they in this PR?
There was a problem hiding this comment.
For the template-only file, it was previously un-asserted.
Since the import path changed (by adding an extension), I thought it might be good to assure the template-only component is in the dist output.
🤷
Supersedes: #199
Resolves: #196
.gtsextensions typed-ember/glint#618