Use native ember types #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
native-types
branch
from
2af6741 to
c53335b
Compare
NullVoxPopuli
changed the base branch from
main
to
ember-source-is-required-for-babel-plugin-ember-template-compilation
simonihmig
reviewed
Nov 10, 2024
| "@types/ember__component": "^4.0.21", | ||
| "@types/ember__modifier": "^4.0.8", | ||
| "@types/ember__helper": "^4.0.5", | ||
| "@types/ember__routing": "^4.0.19", |
Base automatically changed from
ember-source-is-required-for-babel-plugin-ember-template-compilation
to
main
November 10, 2024 21:02
NullVoxPopuli
force-pushed
the
native-types
branch
from
c53335b to
f0f6a3e
Compare
NullVoxPopuli
commented
Nov 11, 2024
| "allowImportingTsExtensions": true, | ||
|
|
||
| "types": [ | ||
| "ember-source/types" |
There was a problem hiding this comment.
matches the TS App Blueprint rn
simonihmig
approved these changes
Dec 18, 2024
NullVoxPopuli
force-pushed
the
native-types
branch
from
e913045 to
0db2a09
Compare
|
rebased! 🎉 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #306
Supersedes: #118