Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use addon-dev declarations plugin for d.ts output #315

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

simonihmig
Copy link
Collaborator

@simonihmig simonihmig commented Dec 9, 2024

After landing embroider-build/embroider#2200 in v7.1.0, we use the new plugin to emit type declarations.

Fixes #215

@simonihmig simonihmig force-pushed the rollup-declarations-plugin branch from f5bac2c to c2275bc Compare December 18, 2024 14:54
@simonihmig simonihmig marked this pull request as ready for review December 18, 2024 14:56
@simonihmig simonihmig requested a review from a team December 18, 2024 14:57
@NullVoxPopuli
Copy link
Collaborator

Yay!

@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Dec 18, 2024
@simonihmig simonihmig merged commit ff9bf7f into main Dec 18, 2024
18 checks passed
@simonihmig simonihmig deleted the rollup-declarations-plugin branch December 18, 2024 16:10
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken declarations emitted when importing .gts files
3 participants