Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate test flakiness of rollup --watch tests on windows in CI #1465

Closed
NullVoxPopuli opened this issue Jun 7, 2023 · 2 comments
Closed

Investigate test flakiness of rollup --watch tests on windows in CI #1465

NullVoxPopuli opened this issue Jun 7, 2023 · 2 comments
Assignees
@NullVoxPopuli

Comments

@NullVoxPopuli
Copy link
Collaborator

passed on the 5th run
https://github.com/embroider-build/embroider/actions/runs/5198120927
@NullVoxPopuli NullVoxPopuli self-assigned this Jun 7, 2023
ef4 added a commit that referenced this issue Jun 13, 2023
@ef4
Removing flaky test
3936fdb 
Mitigates #1465.

These tests are fundamentally not a good way to test this. It's going to be very hard to make them reliable.

It would probably be better to use [rollup.watch](https://rollupjs.org/javascript-api/#rollup-watch) directly because it emits events we can use, instead of trying to parse stderr and use arbitrary delays to guess when changes have propagated.
@ef4
Copy link
Contributor

ef4 commented Jun 13, 2023

I meant to do 3936fdb in a PR but pushed it directly to main by mistake. I have since updated the branch-protection rules so that they also apply to admins (by default they do not).

@NullVoxPopuli NullVoxPopuli mentioned this issue Jun 19, 2023
Merged
@NullVoxPopuli
Copy link
Collaborator Author

Resolved in #1473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NullVoxPopuli NullVoxPopuli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NullVoxPopuli @ef4