Add staticModifiers option
#1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
force-pushed
the
feature/staticModifiers-option
branch
from
455cc03
to
ee65257
Compare
lifeart
reviewed
Nov 17, 2021
| if (node.path.type !== 'PathExpression') { | ||
| return; | ||
| } | ||
| if (node.path.this === true) { |
There was a problem hiding this comment.
we need same for node.path.data === true ({{@foobar}})
There was a problem hiding this comment.
Thanks, didn't know about that!
There was a problem hiding this comment.
Added! I also forgot about "contextual" modifiers so I added that as well.
There was a problem hiding this comment.
@Windvis could we cover "modifier" helper usage?
like
Windvis
force-pushed
the
feature/staticModifiers-option
branch
2 times, most recently
from
0f95933
to
f4c41d1
Compare
lifeart
approved these changes
Nov 17, 2021
This option makes it possible to tree-shake unused modifiers and is the modifier equivalent of staticHelpers and staticComponents.
Windvis
force-pushed
the
feature/staticModifiers-option
branch
from
f4c41d1
to
b159f89
Compare
lifeart
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still need to add tests and actually test if it works 😬I added some tests. Let me know if I missed something 🙏.Closes #603