FIX: rollup-hbs-plugin add resolveId hook #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In the `load()` hook, `id` isn't a valid property in the returned object. - This assumed that a resolution was created for the intermediate file `*.hbs.js` file. - This created an issue where a babel plugin could not transform `*.hbs.js` files. - Added `resolveId()` hook to create a resolution for `*.hbs` to `*.hbs.js` file.
rwjblue
reviewed
Mar 29, 2022
There was a problem hiding this comment.
Thanks for working on this @wondersloth!
@ef4 / @NullVoxPopuli - The issue that @wondersloth is fixing here is the root cause of why .hbs files themselves aren't going through babel transpilation (rollup-plugin-babel only looks at .js files, load isn't allowed to return a new id, so babel was just skipping these .hbs files completely).
rwjblue
reviewed
Mar 29, 2022
rwjblue
approved these changes
Mar 30, 2022
ef4
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load()hook,idisn't a valid property in the returned object.file
*.hbs.jsfile.*.hbs.jsfiles.resolveId()hook to create a resolution for*.hbsto*.hbs.jsfile.