restore original ts extension priority #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I see now. It was bad to have TS before JS (because then libraries that ship both would try to recompile their TS). But it's also bad to have TS after HBS (because when a component has both, it's supposed to be the TS that represents the component). |
|
🙏 |
This was referenced Jan 27, 2023
|
Thank you 🤝 |
This was referenced May 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really know what 7882a2d was trying to achieve and it definitely looks weird and it's the cause of #1336 and probably #1341.
Maybe CI will tell me why this was done in the first place...