Prevent HTML-escaping of module specifiers #1365
Conversation
| @@ -11,4 +11,7 @@ handlebars.registerHelper('json-stringify', function (input: any, indent?: numbe | |||
| handlebars.registerHelper('eq', function (a: any, b: any) { | |||
| return a === b; | |||
| }); | |||
| export const compile = handlebars.compile; | |||
|
|
|||
| export function compile(input: string) { | |||
There was a problem hiding this comment.
Technically, this changes the signature of this function, as you could previously pass custom options. But this was nowhere the case AFAICT. And it seems better to me to not expose this, but own the config internally here.
I can change that of course in case of disagreement!
|
Failing test scenarios seem to be related to #1366 |
|
Previously I had done this in each place it came up by using triple curlies. I like your solution better, but we should remove all the triple curlies too so it's not confusing. |
simonihmig
force-pushed
the
prevent-escape
branch
from
0987ab7
to
4485f71
Compare
@ef4 done! Still getting a bunch of failed CI jobs due to some network issues when installing node, even after re-running them... |
simonihmig
force-pushed
the
prevent-escape
branch
from
4485f71
to
b5b840b
Compare
simonihmig
force-pushed
the
prevent-escape
branch
from
b5b840b
to
17e2f6b
Compare
|
Thanks for working on this, I think it's ready to go. |
Switching a pnpm-based repo to its newer
lockfileVersion: '6.0'causednode_modulesto have folders containing an=equal sign (for patched packages), which breaks the build as that equal sign gets wrongly HTML-escaped to=, causing module not found errors.This PR basically replicates the same fix as for ember-auto-import.
I was able to confirm - by patching the local file in
node_moduleswith the same changes as in this PR - that it fixes the build issue I had.