Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Maximum call stack size exceeded error #1386

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

simonihmig
Copy link
Collaborator

Today I was running into the same issue that @void-mAlex has reported in yesterday's office hours, and as we discussed it removing the exports from the rewritten package.json indeed fixes the problem. At least for me, maybe @void-mAlex you can double check that on your side too?

@void-mAlex
Copy link
Collaborator

it was also desirable to give the better error in case the loop comes up for any other scenario, will try both this fix and the change for the error as soon as I get some time

@ef4
Copy link
Contributor

ef4 commented Mar 29, 2023

After our discussions yesterday, I'm pretty convinced this is correct. It's consistent with the way we already rewrite v1 addons.

it was also desirable to give the better error in case the loop comes up for any other scenario,

Agreed, stopping the cycle is also good.

@ef4 ef4 merged commit dda695f into main Mar 31, 2023
@ef4 ef4 deleted the fix-call-stack-exceeded branch March 31, 2023 14:51
This was referenced May 2, 2023
@ef4 ef4 added the bug Something isn't working label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants