Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prepare changelog workflow to automatically propose what should be in sync for us #1398

Merged

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Apr 19, 2023

Supersedes #1360

Here is a demo of it running on my fork: https://github.com/NullVoxPopuli/embroider/actions/runs/4746443242/jobs/8430099950

And here is the PR it created: NullVoxPopuli#1

And here is the PR for resolving all the TODOs, and verifying impact / affected packages: #1401

I still need to add support for an .changesetignore~style file for ignoring certain changes (or ignoring aggregated things)

But the proposed workflow here is less manual than before:

  1. wait for one of these PRs to be opened
  2. go through the TODOs
  3. create another PR with the TODOs taken care of
  4. merge
  • this can happen async with other work (and by anyone who wants to review merged PRs and assess impact, or create more detailed changelog entries) -- the main thing is that the automation gets the process started.
  • this can also happen incrementally, a PR that submits these changeset entries does not need to contain all of them

For an example of how detailed the changelog entries can get: https://github.com/NullVoxPopuli/ember-resources/blob/main/.changeset/gold-weeks-destroy.md?plain=1
And how it looks rendered in the changelog: https://github.com/NullVoxPopuli/ember-resources/blob/main/ember-resources/CHANGELOG.md#major-changes-2

@NullVoxPopuli NullVoxPopuli merged commit df7f441 into embroider-build:main Apr 25, 2023
@NullVoxPopuli NullVoxPopuli deleted the changelog-sync-automation branch April 25, 2023 18:57
@ef4 ef4 added the internal label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants