Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Run the clean plugin of addon-dev as late as possible" #1446

Merged
merged 1 commit into from
May 30, 2023

Conversation

mansona
Copy link
Member

@mansona mansona commented May 24, 2023

This reverts the change made in #1229

Essentially if you have any plugins that are outputting files in the build phase (before generateBundle) then they will be deleted. This is too aggressive as a default and doesn't actually solve the issue of noisy rebuilds 😞

@mansona mansona added the bug Something isn't working label May 24, 2023
@mansona mansona requested review from simonihmig, ef4 and a team May 24, 2023 16:02
@ef4 ef4 merged commit ea4b13f into main May 30, 2023
@ef4 ef4 deleted the revert-late-clean branch May 30, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants