Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating pnpm #1535

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Updating pnpm #1535

merged 1 commit into from
Jul 15, 2023

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jul 15, 2023

  • updates pnpm
  • keeps auto-install-peers false, which was the old default. It does some pretty wrong things if we turn it on, probably because of upstream misdeclared peerDeps.
  • dropping the old inter-version-test because we now use workspace: protocol exclusively and it maintains our inter-version dependency numbers, which the test was written to check

@ef4
Updating pnpm
4559a9f 
 - updates pnpm
 - keeps auto-install-peers to false, because it makes some pretty disastrous decisions otherwise.
 - dropping the old inter-version-test because we now use workspace: protocol exclusively and it maintains our inter-version dependency numbers, which the test was written to check
@ef4 ef4 merged commit 1cdd50c into main Jul 15, 2023
196 checks passed
@ef4 ef4 deleted the pnpm-updates branch July 15, 2023 06:07
@ef4 ef4 added the internal label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ef4