Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize port and improve watch mode test #1629

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

chancancode
Copy link
Contributor

No description provided.

}
}

type Status = { type: 'starting' } | { type: 'ready' } | { type: 'errored'; error: unknown } | { type: 'completed' };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It kinda feels like this whole util belongs in ember-cli and should have its own tests.
But that would mean ember-cli would need to formally support a js api, which could probably be implemented without stream peaking
🙃 idk.

Looks solid tho!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I called it EmberCLI but it really is just a stateful child process thing with facilities for testing outputs, which I am sure could be useful for testing the vite integrations and what not as well

@chancancode chancancode force-pushed the improve-watch-tests branch 2 times, most recently from 6b1d31b to 52f2a46 Compare October 7, 2023 06:01
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 🎉 I think the helper classes have gotten a bit complicated now that we could benefit from them being moved into a separate file so that the test are easier to follow, but that's not a blocker for merging this 👍

@mansona mansona merged commit 38a3aa7 into embroider-build:main Oct 7, 2023
202 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants