Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf: Only require.resolve the babel plugin cache busting file once #1644

Conversation

raycohen
Copy link
Contributor

@raycohen raycohen commented Oct 15, 2023

This gets hit many times during the ember-cli startup phase where the addon graph is initialized, and then once per rebuild. The value shouldn't change, so we can just run it once.

Caching removes the cost highlighted:
resolve-before

@raycohen raycohen changed the title only require.resolve the babel plugin cache busting file once Perf: only require.resolve the babel plugin cache busting file once Oct 15, 2023
@raycohen raycohen changed the title Perf: only require.resolve the babel plugin cache busting file once Perf: Only require.resolve the babel plugin cache busting file once Oct 15, 2023
@raycohen raycohen marked this pull request as ready for review October 15, 2023 02:20
@ef4 ef4 merged commit 65d9067 into embroider-build:main Oct 16, 2023
208 checks passed
@ef4 ef4 added the bug Something isn't working label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants