Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide base path from public URL of rollup-public-assets #1697

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Hide base path from public URL of rollup-public-assets #1697

merged 1 commit into from
Dec 11, 2023

Commits on Dec 4, 2023

  1. Hide base path from public URL of rollup-public-assets 

    This change is to enable a v2 addon to expose its public assets under the same URL as a v1 addon would. But currently, the public URL would always include the base path that you pass into the rollup plugin. Say if your v1 addon `my-addon` had `public/foo/bar.jpg`, it would expose taht under the URL of `/my-addon/foo/bar.jpg`. But if converting that to v2 and putting the file into e.g. `src/public/foo/bar.jpg`, then using the rollup plugin it would be exposed as `/my-addon/src/public/foo/bar.jpg`, and no way to get rid off the path (`src/public`).

This change is removing that, which makes this a breaking one.
    @simonihmig
    simonihmig committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    ee9b6b2 View commit details
    Browse the repository at this point in the history