Fix incorrect ownerOfFile at root of filesystem #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ownerOfFile gets to the root of the filesystem it ends up trying to check the path `''` which then goes through realpathSync and becomes the current working directory. This causes any unowned file to incorrectly get attributed to the app.
Merged
NullVoxPopuli
approved these changes
Jan 18, 2024
ef4
added a commit
that referenced
this pull request
May 28, 2024
#1762 only fixed the bug on unix. On windows the bug is still lurking.
ef4
added a commit
that referenced
this pull request
May 28, 2024
#1762 only fixed the bug on unix. On windows the bug is still lurking.
ef4
added a commit
that referenced
this pull request
May 28, 2024
#1762 only fixed the bug on unix. On windows the bug is still lurking.
ef4
added a commit
that referenced
this pull request
May 28, 2024
#1762 only fixed the bug on unix. On windows the bug is still lurking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ownerOfFile gets to the root of the filesystem it ends up trying to check the path
''which then goes through realpathSync and becomes the current working directory. This causes any unowned file to incorrectly get attributed to the app.