Make macro configs static #1823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
reviewed
Feb 28, 2024
|
yeah, I wasn't sure how we plan that!? I guess it depends how far the two branches diverged, and where the changes on stable happened? Changes in the macro package should be easy to merge, but not sure if we have others that cause crazy merge conflicts, or that we even don't want in |
|
essentially we agreed collectively that we want to do this stuff as "forward merges" from stable to main, I'll give it a go and see how far I get :) |
|
Didn't seem like too hard a merge 👍 #1825 |
|
Even better, closing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1815, this time targeting
main