Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Webpack: close the compiler" #1981

Merged

Conversation

krasnoukhov
Copy link
Contributor

@krasnoukhov krasnoukhov commented Jun 12, 2024

Revert of #1971 #1978

Sorry for causing trouble with this, but that change broke rebuild. Since embroider reuses the compiler for rebuilds we can't close it because otherwise rebuilds won't work.

Maybe it would be possible to close it when process is about to exit, to save the cache if we're running the regular build, but I don't want to complicate this.

@krasnoukhov
Copy link
Contributor Author

cc @mansona @ef4

@void-mAlex void-mAlex added bug Something isn't working labels Jun 12, 2024
@void-mAlex void-mAlex merged commit 06e9c9f into embroider-build:stable Jun 12, 2024
203 checks passed
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@krasnoukhov krasnoukhov deleted the revert-webpack-close branch June 12, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants